Fix GH-8563#8651
Conversation
|
Ah great, this hits the issue 188b1d4 which was fixed in 8.1 |
|
Actually... I'm wondering if this is going to break non standard CSV files which have an empty line somewhere in the file (which is obviously untested). |
I think we should add tests for that. The current behavior is somewhat suprising: https://3v4l.org/PS0El; only if |
With memory streams if we get a NULL buffer we must not instantiate an empty line
|
Seems like my fix might indeed be correct as it does not break it (however while merging up the NULL will need to be changed to false) |
cmb69
left a comment
cmb69
left a comment
There was a problem hiding this comment.
Yeah, I think this is good to be merged.
I'm not sure, though, about renaming the existing tests (i.e. moving them to a subdirectory); maybe postpone that to "master".
|
Merged as 6f87a5c |
3 participants
With memory streams if we get a NULL buffer we must not instantiate an empty line.
Splitting this from #8644 as this one seems to be fixed properly